add possibility to use different hash algorithms in RSAES-OAEP #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timlegge
force-pushed
the
rsa-oaep-mgf-paramdigest
branch
from
ce3160a
to
d5279fd
Compare
|
I don't mind adding the required libtom to the PR but I figured that you would have more expertise in that process |
karel-m
reviewed
Mar 18, 2023
inc/CryptX_PK_RSA.xs.inc
Outdated
| @@ -295,10 +295,10 @@ export_key_der(Crypt::PK::RSA self, char * type) | |||
| RETVAL | |||
|
|
|||
| SV * | |||
| encrypt(Crypt::PK::RSA self, SV * data, const char * padding = "oaep", const char * oaep_hash = "SHA1", SV * oaep_lparam = NULL) | |||
| encrypt(Crypt::PK::RSA self, SV * data, const char * padding = "oaep", const char * mgf_hash = "SHA1", const char * lparam_hash = "SHA1", SV * oaep_lparam = NULL) | |||
There was a problem hiding this comment.
const char * lparam_hash = "SHA1" should be added as the last parameter with default set to mfg_hash value otherwise it will break compatibility
There was a problem hiding this comment.
Done
It probably needs some pod updates at
perl-CryptX/lib/Crypt/PK/RSA.pm
Line 587 in d4403a4
timlegge
force-pushed
the
rsa-oaep-mgf-paramdigest
branch
from
d5279fd
to
15861fe
Compare
Requires changes from libtom libtom/libtomcrypt#612
timlegge
force-pushed
the
rsa-oaep-mgf-paramdigest
branch
from
15861fe
to
d54c7af
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires changes from libtom libtom/libtomcrypt#612