-
-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: Docker #946
refactor: Docker #946
Conversation
You can mark the PR as a draft. |
So Like said in the original PR it might be worth considering issue #944. Although related to documentation, the changes proposed there don't directly impact the Docker configurations. However, as suggested in the issue, cleaning up the documentation and merging the building.md markdown into a readme in the development folder could streamline the user experience. This way, users will have everything conveniently located in one place. |
I'm not sure that the start and stop Docker scripts in the bin folder are still needed since Docker Compose already does it automatically ? |
noone really knows as we never really worked on it anyway |
@1day2die so I can delete what I think is not useful anymore and even modify the documentations for dockers ? so that I can make you a working development docker and standalone ? |
…sy deployment and managability
yes |
I think the standalone docker is ready, I just need you @1day2die to test it by going to if yes its that I succeeded and so you can make an official docker image in docker hub https://docs.docker.com/guides/walkthroughs/publish-your-image/, I will then try to publish it to platform like unraid |
Docker GitHub workflow
The docker is finished, documentation could be upgraded but will be done in the futur |
[Bug] ControlPanel leftovers changed to CtrlPanel
I mean... its like 4 month that we are running it in a docker on our side but it have not been tested by many people only us and james |
I'm currently addressing issue #938, though it's still a work in progress. (do not merge for the moment)
The current code incorporates two Docker configurations: one for development and another for deployment, catering to Unraid users.
I've organized these configurations into two folders:
Development: This folder houses the original Docker setup tailored for development purposes.
Standalone: Here, you'll find a modified Docker setup focused solely on running the CtrlPanel with an integrated Nginx. This streamlined setup requires only an external database and Pterodactyl to function efficiently.
I plan to include comprehensive documentation for the standalone setup to ensure ease of use and understanding.
known issue :