Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: request connected identity commitment #798

Merged
merged 7 commits into from
Sep 6, 2023
Merged

feat: request connected identity commitment #798

merged 7 commits into from
Sep 6, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Aug 31, 2023 •
edited
Loading

Explanation

This PR adds suppor for revealing connected identity commitment.

Details are below:

  • Add request commitment page
  • Update demo to get identity commitment
  • Add event for revealing commitment
  • Update cryptkeeper sdk
  • Add tabs permissions
  • Fix event format for credentials
  • Fix reading connected identity

More Information

Closes #313
Blocked by #796

Screenshots/Screencaps

image
image
image

Manual Testing Steps

  1. Connect to demo
  2. Click "Reveal" button and follow the flow
  3. Check if identity commitment is displayed on demo
  4. Check activity tab
  5. Check other websites don't get revealed identity commitment

Pre-Merge Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Aug 31, 2023
@0xmad 0xmad self-assigned this Aug 31, 2023
@0xmad 0xmad added this to the v0.0.3 milestone Aug 31, 2023
@0xmad 0xmad force-pushed the feature/request-identity-commitment branch 2 times, most recently from 445bbdc to c3d684a Compare September 1, 2023 16:21
@0xmad 0xmad marked this pull request as ready for review September 1, 2023 16:25
0xisk
0xisk requested changes Sep 4, 2023
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @0xmad, manual testing is passed, just left this comment and rebasing with the main branch.

packages/app/src/background/services/zkIdentity/index.ts Outdated Show resolved Hide resolved
@0xmad 0xmad requested a review from 0xisk September 4, 2023 13:55
@0xmad 0xmad force-pushed the feature/request-identity-commitment branch from c3d684a to 55e920a Compare September 4, 2023 13:58
0xisk
0xisk approved these changes Sep 4, 2023
View reviewed changes
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @0xmad!

@0xmad 0xmad force-pushed the feature/request-identity-commitment branch 4 times, most recently from 5e458d6 to 240fe96 Compare September 5, 2023 21:16
@0xmad
feat: request connected identity commitment
5b67052 
- [x] Add request commitment page
- [x] Update demo to get identity commitment
- [x] Add event for revealing commitment
- [x] Update cryptkeeper sdk
- [x] Add tabs permissions
- [x] Fix event format for credentials
- [x] Fix reading connected identity
@0xmad
fix: update inactive tabs
3da31df
@0xmad
fix: speed up build
9e600d0
@0xmad
test: add e2e tests
e8cba46
@0xmad
fix: use one method for identity metadata
1961dac
@0xmad
chore: fix lint and add tests
96c0d3a
@0xmad 0xmad force-pushed the feature/request-identity-commitment branch from 240fe96 to 96c0d3a Compare September 5, 2023 23:51
@0xmad 0xmad enabled auto-merge (squash) September 5, 2023 23:58
@0xmad 0xmad merged commit c4c3830 into main Sep 6, 2023
10 checks passed
@0xmad 0xmad deleted the feature/request-identity-commitment branch September 6, 2023 00:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xisk 0xisk 0xisk approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xmad 0xmad

Labels
🌱 new feature Troubleshooting new feature issues
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.3.0
Development

Successfully merging this pull request may close these issues.

feat: CK injection APIs ckpr.requestIdentityCommitment
2 participants
@0xmad @0xisk