Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: generating semaphore proofs in firefox with mv2 #657

Merged
merged 5 commits into from
Jul 20, 2023
Merged

fix: generating semaphore proofs in firefox with mv2 #657

merged 5 commits into from
Jul 20, 2023

Conversation

0xisk
Copy link
Member

@0xisk 0xisk commented Jul 19, 2023

Explanation

This PR adds support for generating Semaphore Proofs for Firefox using MV2.

More Information

Screenshots/Screencaps

N/A

Manual Testing Steps

  • Regular testing steps on Firefox with the demo.

Pre-Merge Checklist

  • PR template is filled out
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

PR template source from github.com/MetaMask

@0xisk 0xisk added the 🪲 bug Something isn't working label Jul 19, 2023
@0xisk 0xisk self-assigned this Jul 19, 2023
@0xisk 0xisk added this to the v0.1.0-beta milestone Jul 19, 2023
0xmad
0xmad reviewed Jul 19, 2023
View reviewed changes
Copy link
Member

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk thanks

packages/app/.eslintignore Outdated Show resolved Hide resolved
packages/app/src/background/services/injector/index.ts Outdated Show resolved Hide resolved
packages/app/webpack.common.js Outdated Show resolved Hide resolved
packages/app/webpack.common.js Outdated Show resolved Hide resolved
packages/app/src/background/shared/subworkers.js Outdated Show resolved Hide resolved
@0xmad 0xmad changed the title fix: generating SemaphoreProofs in Firefox with MV2 fix: generating semaphore proofs in firefox with mv2 Jul 19, 2023
0xmad
0xmad approved these changes Jul 19, 2023
View reviewed changes
Copy link
Member

@0xmad 0xmad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xisk thanks!

@0xisk 0xisk force-pushed the fix/semaphore-proof-firefox branch from 3759ef8 to f51f572 Compare July 20, 2023 10:47
@0xisk 0xisk merged commit bb6f3ed into main Jul 20, 2023
16 of 17 checks passed
@0xisk 0xisk deleted the fix/semaphore-proof-firefox branch July 20, 2023 10:47
AndrewCLu pushed a commit that referenced this pull request Jul 25, 2023
@0xisk @AndrewCLu
fix: generating semaphore proofs in firefox with mv2 (#657)
f19ac73 
* fix: generating SemaphoreProofs in Firefox with MV2

* chore: run preittier

* chore: run preittier

* chore: run preittier

* fix: requested changes and unit-test error
@0xisk 0xisk mentioned this pull request Aug 20, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xmad 0xmad 0xmad approved these changes

@AtHeartEngineer AtHeartEngineer Awaiting requested review from AtHeartEngineer AtHeartEngineer is a code owner

Assignees

@0xisk 0xisk

Labels
🪲 bug Something isn't working
Projects
Crypt-Keeper Extension
Status: ✅ Done
Milestone
v0.1.0-beta
Development

Successfully merging this pull request may close these issues.
2 participants
@0xisk @0xmad