Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: import json identity #1037

Merged
merged 1 commit into from
Oct 19, 2023
Merged

feat: import json identity #1037

merged 1 commit into from
Oct 19, 2023

Conversation

0xmad
Copy link
Member

@0xmad 0xmad commented Oct 17, 2023

Explanation

This PR adds support for uploading json file with external identity data

Details are below:

  • Support file upload for import external identity
  • Add upload button component
  • Add e2e tests

Related Issues

Related to #906

Screenshots

Expand

image

Manual Testing Steps

Try to import identity with file (example are in packages/e2e/backups)

Pre-Merge Checklist

Assignees Checklist

  • PR template is filled out
  • Pre-commit and pre-push hook checks are passed
  • E2E tests are passed locally
  • IF this PR fixes a bug, a test that would have caught the bug has been added
  • PR is linked to the appropriate GitHub issue
  • PR has been added to the appropriate release Milestone

Reviewers Checklist

  • Manual testing checked and passed.

@0xmad 0xmad added the 🌱 new feature Troubleshooting new feature issues label Oct 17, 2023
@0xmad 0xmad added this to the v0.6.0 milestone Oct 17, 2023
@0xmad 0xmad self-assigned this Oct 17, 2023
@0xmad 0xmad force-pushed the feature/import-json-identity branch 2 times, most recently from ddd3261 to cc30cb6 Compare October 17, 2023 16:27
@0xmad 0xmad force-pushed the feature/import-json-identity branch 2 times, most recently from 1850263 to c8d33ce Compare October 18, 2023 23:33
- [x] Support file upload for import external identity
- [x] Add upload button component
- [x] Add e2e tests
@0xmad 0xmad force-pushed the feature/import-json-identity branch from c8d33ce to a9c3ba6 Compare October 19, 2023 02:39
Copy link
Member

@0xisk 0xisk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @0xmad!

@0xmad 0xmad merged commit 28d4467 into main Oct 19, 2023
10 checks passed
@0xmad 0xmad deleted the feature/import-json-identity branch October 19, 2023 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 new feature Troubleshooting new feature issues
Projects
Status: ✅ Done
Development

Successfully merging this pull request may close these issues.

2 participants