chore: refactor fns to utilize latest go SDK offerings #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsteenb2
force-pushed
the
chore/refactor_fns
branch
from
e8a833e
to
1eb14b7
Compare
jsteenb2
force-pushed
the
chore/refactor_fns
branch
from
1eb14b7
to
8d0b70e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
as we're trying to improve the go sdk we're running into a blocker here with sample apps. These apps are using old patterns and b/c of this, are tangled up in parts we don't want touched directly. This updates it to take advantage of what the SDK offers, removing the need for a lot of boilerplate. Additionally, it frees up the SDK to make the important but technically breaking changes. None of the other fns hit this, as they're utilizing the SDK helpers instead of creating boilerplate to do it. After this update, we're in the free to update the SDK with this breaking change, that won't actually break anyone. The power of solid helper fns heh