feat: add cluster visibility to FalconAdmission #583
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gpontejos
force-pushed
the
gpontejos/kac-visibility
branch
2 times, most recently
from
5623c3e
to
f4c24f9
Compare
mhyson-cs
requested changes
Oct 1, 2024
gpontejos
force-pushed
the
gpontejos/kac-visibility
branch
from
01cbb4d
to
7a229ab
Compare
mhyson-cs
requested changes
Oct 1, 2024
Comment on lines
251
to
252
| defaultSnapshotInterval, _ := time.ParseDuration("22h0m0s") | ||
| return defaultSnapshotInterval |
There was a problem hiding this comment.
Parsing isn't necessary here. You can just return 22 * time.Hour.
gpontejos
force-pushed
the
gpontejos/kac-visibility
branch
from
7a229ab
to
fffc69b
Compare
gpontejos
force-pushed
the
gpontejos/kac-visibility
branch
from
fffc69b
to
d00c5d3
Compare
mhyson-cs
approved these changes
Oct 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.