Merge pull request #128 from NullVoxPopuli/NullVoxPopuli-patch-1-2

Allow floaty bit to hide appropriately
CrowdStrike · Aug 24, 2023 · 3347f8c · 3347f8c
2 parents 6dc9ac9 + 21c18b4
commit 3347f8c
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/.changeset/fair-taxis-lay.md b/.changeset/fair-taxis-lay.md
@@ -0,0 +1,5 @@
+---
+"ember-velcro": patch
+---
+
+Fixes an issue with visibility
diff --git a/ember-velcro/src/modifiers/velcro.ts b/ember-velcro/src/modifiers/velcro.ts
@@ -88,11 +88,15 @@ export default class VelcroModifier extends Modifier<Signature> {
         strategy,
       });
 
+      const { referenceHidden } = middlewareData.hide;
+
       Object.assign(floatingElement.style, {
         top: `${y}px`,
         left: `${x}px`,
         margin: 0,
+        visibility: referenceHidden ? 'hidden' : 'visible',
       });
+
       setVelcroData?.(middlewareData.metadata);
     };