Skip to content

Commit

Permalink
Temporarily disable embroider-optimized tests
Browse files Browse the repository at this point in the history
  • Loading branch information
ynotdraw committed Jul 11, 2023
1 parent abbc22a commit 91d047f
Showing 1 changed file with 27 additions and 24 deletions.
51 changes: 27 additions & 24 deletions test-app/config/ember-try.js
Original file line number Diff line number Diff line change
Expand Up @@ -41,30 +41,33 @@ module.exports = async function () {
},
},
},
embroiderOptimized({
name: 'ember-lts-4.8 + embroider-optimized',
npm: {
devDependencies: {
'ember-source': '~4.8.0',
// @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383, which should be https://github.com/embroider-build/embroider/pull/1408
'@embroider/core': '2.1.2-unstable.c58f146',
'@embroider/compat': '2.1.2-unstable.c58f146',
'@embroider/webpack': '2.1.2-unstable.c58f146',
},
},
}),
embroiderOptimized({
name: 'ember-release + embroider-optimized',
npm: {
devDependencies: {
'ember-source': releaseVersion,
// @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383, which should be https://github.com/embroider-build/embroider/pull/1408
'@embroider/core': '2.1.2-unstable.c58f146',
'@embroider/compat': '2.1.2-unstable.c58f146',
'@embroider/webpack': '2.1.2-unstable.c58f146',
},
},
}),
// @todo
// Temporarily disabling embroider optimized tests due to https://github.com/CrowdStrike/ember-toucan-core/issues/210

// embroiderOptimized({
// name: 'ember-lts-4.8 + embroider-optimized',
// npm: {
// devDependencies: {
// 'ember-source': '~4.8.0',
// // @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383, which should be https://github.com/embroider-build/embroider/pull/1408
// '@embroider/core': '2.1.2-unstable.c58f146',
// '@embroider/compat': '2.1.2-unstable.c58f146',
// '@embroider/webpack': '2.1.2-unstable.c58f146',
// },
// },
// }),
// embroiderOptimized({
// name: 'ember-release + embroider-optimized',
// npm: {
// devDependencies: {
// 'ember-source': releaseVersion,
// // @todo remove this once we have a stable release that includes https://github.com/embroider-build/embroider/pull/1383, which should be https://github.com/embroider-build/embroider/pull/1408
// '@embroider/core': '2.1.2-unstable.c58f146',
// '@embroider/compat': '2.1.2-unstable.c58f146',
// '@embroider/webpack': '2.1.2-unstable.c58f146',
// },
// },
// }),
],
};
};

0 comments on commit 91d047f

Please sign in to comment.