fix: save table column order on setAll #200

joelamb · 2023-06-20T16:37:32Z

enable re-ordered columns to be saved to preferences

changeset-bot · 2023-06-20T16:37:35Z

🦋 Changeset detected

Latest commit: ced9ca3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
ember-headless-table	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2023-06-20T16:44:16Z

Preview URLs

GH Env: preview
docs: https://06fab8fb.ember-headless-table.pages.dev
api docs: https://06fab8fb.ember-headless-table.pages.dev/api/modules.html

ember-headless-table/src/plugins/column-reordering/plugin.ts

NullVoxPopuli · 2023-06-22T11:22:34Z

.changeset/thin-sheep-warn.md

@@ -0,0 +1,8 @@
+---
+"ember-headless-table": patch
+"test-app": patch


test-app needs to be private 🙃

updated changeset

nicolechung · 2023-06-22T16:24:46Z

Suggestion: It would be helpful if we showed how this works with preferences in the docs:

The description of how to use it with preferences exists, but could stand to have a bit more detail (a demo or a code snippet of how to set it up)

nicolechung · 2023-06-22T17:15:47Z

test-app/tests/plugins/column-reordering/rendering-test.gts

+              }
+            }
+          },
+          "ColumnVisibility": {


Question: why is ColumnVisibility here? Was that set up from a previous test?

It's because the tests in this module are set up with the Column Visibility plugin on line 376, and including that module adds the property to the preferences object

joelamb · 2023-06-23T10:39:12Z

@nicolechung Code snippet added to documentation for Column Reordering. There is no setup required - the preferences object is automatically created when the plugin is included. It's up to the consuming app to handle where and how to save the provided object.

ynotdraw

Change looks good to me! To get a release you'll still want to do pnpm changeset and select ember-headless-table as the package to bump!

ynotdraw · 2023-06-26T12:22:04Z

test-app/tests/plugins/column-reordering/rendering-test.gts

+      // @ts-expect-error
+      setColumnOrder(ctx.table, order);


Not being in this repo much:

Out of curiosity - why is this @ts-expect-error required? Are we not supposed to be calling this directly? Adding a comment here for future travelers may be helpful.

Without it I get a TS error

setColumnOrder is not usually called directly (it's in the helpers.ts) so we're OK to ignore the TS error here.

nicolechung · 2023-06-26T12:50:07Z

.github/actions/pnpm/action.yml

@@ -5,7 +5,7 @@ runs:
  steps:
    - uses: pnpm/[email protected]
      with:
-        version: 7
+        version: 7.32.5


Just curious, why this update?

see #199

It's to address an issue around pnpm lock files

nicolechung · 2023-06-26T13:15:32Z

Code snippet added to documentation for Column Reordering. There is no setup required - the preferences object is automatically created when the plugin is included. It's up to the consuming app to handle where and how to save the provided object

I didn't fully read this the first time (osrry, Monday morning) and left a suggestion and then re-read your comment and deleted it. Pretty neat that the preferences object is automatically created!

enable re-ordered columns to be saved to preferences

github-actions bot deployed to ember-headless-table (Preview) June 20, 2023 16:42 View deployment

joelamb requested review from vitch, nicolechung, ynotdraw and clintcs June 20, 2023 16:47

ynotdraw reviewed Jun 20, 2023

View reviewed changes

ember-headless-table/src/plugins/column-reordering/plugin.ts Show resolved Hide resolved

joelamb force-pushed the add-engines-field-to-package-json branch from 53380c4 to 11eb4bc Compare June 21, 2023 13:47

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch 2 times, most recently from a4f54f1 to 5595c9c Compare June 21, 2023 13:52

github-actions bot requested a deployment to ember-headless-table (Preview) June 21, 2023 13:59 Abandoned

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch from 5595c9c to 332a139 Compare June 21, 2023 14:00

github-actions bot deployed to ember-headless-table (Preview) June 21, 2023 14:04 View deployment

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch from 332a139 to 8fda789 Compare June 21, 2023 14:31

github-actions bot deployed to ember-headless-table (Preview) June 21, 2023 14:35 View deployment

joelamb requested a review from ynotdraw June 22, 2023 08:42

github-actions bot deployed to ember-headless-table (Preview) June 22, 2023 08:45 View deployment

NullVoxPopuli reviewed Jun 22, 2023

View reviewed changes

nicolechung reviewed Jun 22, 2023

View reviewed changes

github-actions bot deployed to ember-headless-table (Preview) June 23, 2023 08:37 View deployment

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch from 54653c0 to ee5bcab Compare June 23, 2023 10:31

github-actions bot deployed to ember-headless-table (Preview) June 23, 2023 10:36 View deployment

joelamb requested review from NullVoxPopuli and nicolechung June 23, 2023 10:39

ynotdraw approved these changes Jun 26, 2023

View reviewed changes

nicolechung reviewed Jun 26, 2023

View reviewed changes

nicolechung approved these changes Jun 26, 2023

View reviewed changes

Base automatically changed from add-engines-field-to-package-json to main June 27, 2023 14:54

fix: save table column order on setAll

35480ee

enable re-ordered columns to be saved to preferences

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch from ee5bcab to 7d7d2ae Compare June 27, 2023 14:58

github-actions bot deployed to ember-headless-table (Preview) June 27, 2023 15:02 View deployment

joelamb added 2 commits June 28, 2023 10:46

test: set all persists column order to preferences

ca3255b

chore: update coloumn reordering docs with preferences example

9d07304

joelamb force-pushed the persist-reordered-cols-in-user-prefs branch from 7d7d2ae to 9d07304 Compare June 28, 2023 09:53

github-actions bot deployed to ember-headless-table (Preview) June 28, 2023 09:57 View deployment

Create wet-melons-hunt.md

ced9ca3

github-actions bot deployed to ember-headless-table (Preview) June 29, 2023 08:44 View deployment

joelamb merged commit 9af0da9 into main Jun 29, 2023
25 checks passed

joelamb deleted the persist-reordered-cols-in-user-prefs branch June 29, 2023 09:01

github-actions bot mentioned this pull request Jun 29, 2023

Version Packages #180

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: save table column order on setAll #200

fix: save table column order on setAll #200

joelamb commented Jun 20, 2023

changeset-bot bot commented Jun 20, 2023 •

edited

Loading

github-actions bot commented Jun 20, 2023 •

edited

Loading

NullVoxPopuli Jun 22, 2023

joelamb Jun 23, 2023

nicolechung commented Jun 22, 2023 •

edited

Loading

nicolechung Jun 22, 2023

joelamb Jun 23, 2023 •

edited

Loading

joelamb commented Jun 23, 2023 •

edited

Loading

ynotdraw left a comment

ynotdraw Jun 26, 2023 •

edited

Loading

joelamb Jun 27, 2023 •

edited

Loading

joelamb Jun 29, 2023

nicolechung Jun 26, 2023

joelamb Jun 27, 2023

nicolechung commented Jun 26, 2023

fix: save table column order on setAll #200

fix: save table column order on setAll #200

Conversation

joelamb commented Jun 20, 2023

changeset-bot bot commented Jun 20, 2023 • edited Loading

🦋 Changeset detected

github-actions bot commented Jun 20, 2023 • edited Loading

Preview URLs

NullVoxPopuli Jun 22, 2023

Choose a reason for hiding this comment

joelamb Jun 23, 2023

Choose a reason for hiding this comment

nicolechung commented Jun 22, 2023 • edited Loading

nicolechung Jun 22, 2023

Choose a reason for hiding this comment

joelamb Jun 23, 2023 • edited Loading

Choose a reason for hiding this comment

joelamb commented Jun 23, 2023 • edited Loading

ynotdraw left a comment

Choose a reason for hiding this comment

ynotdraw Jun 26, 2023 • edited Loading

Choose a reason for hiding this comment

joelamb Jun 27, 2023 • edited Loading

Choose a reason for hiding this comment

joelamb Jun 29, 2023

Choose a reason for hiding this comment

nicolechung Jun 26, 2023

Choose a reason for hiding this comment

joelamb Jun 27, 2023

Choose a reason for hiding this comment

nicolechung commented Jun 26, 2023

changeset-bot bot commented Jun 20, 2023 •

edited

Loading

github-actions bot commented Jun 20, 2023 •

edited

Loading

nicolechung commented Jun 22, 2023 •

edited

Loading

joelamb Jun 23, 2023 •

edited

Loading

joelamb commented Jun 23, 2023 •

edited

Loading

ynotdraw Jun 26, 2023 •

edited

Loading

joelamb Jun 27, 2023 •

edited

Loading