Update JEI integration and add potion fluids to the ingredient list #6934
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This also resolves a minor issue where all virtual fluids were considered "flowing". Fixes mezz/JustEnoughItems#3754
IThundxr
added
pr type: fix
Fixed JEI potion fluids registered without Bottle tag
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This feature was requested on my GitHub for JEI, but I found that it required a small update to Create in order to work.
Fixes mezz/JustEnoughItems#3754
This also resolves a minor issue where all virtual fluids were registered in a way that they were considered "flowing".
I doubt that was causing many issues but it did impact the fluid tooltips in JEI.
Note that tooltips callbacks are simplified in the latest JEI, you can only append to the tooltip.
The end result is slightly less fancy (fluid amount is on its own line) but the same functionality has been preserved.
JEI has improved fluid tooltips compared to before, and so some fluid tooltip logic in Create was made redundant and was able to be removed.
I have added a minimum version requirement for JEI (
15.19.0.+) if it is present, because I added new APIs to JEI in order to support this feature.