Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add macro to add the contract state version as a custom section #2124

Merged
merged 12 commits into from
Apr 25, 2024
Merged

Add macro to add the contract state version as a custom section #2124

merged 12 commits into from
Apr 25, 2024

Conversation

aumetra
Copy link
Member

@aumetra aumetra commented Apr 23, 2024

Closes #2116

@aumetra
Copy link
Member Author

aumetra commented Apr 23, 2024

We could also make this part of the logic of entry_point, that way we don't need to pass the same function twice through a proc-macro facility and through syn parsing

chipshort
chipshort reviewed Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work. Some questions inline.

packages/derive/src/lib.rs Outdated Show resolved Hide resolved
packages/derive/src/lib.rs Outdated Show resolved Hide resolved
@aumetra aumetra requested a review from chipshort April 24, 2024 13:29
chipshort
chipshort approved these changes Apr 24, 2024
View reviewed changes
Copy link
Collaborator

@chipshort chipshort left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aumetra aumetra force-pushed the aw/set-contract-state-version branch from 7c1f5fd to 41632e0 Compare April 24, 2024 14:46
webmaster128
webmaster128 reviewed Apr 25, 2024
View reviewed changes
packages/derive/src/lib.rs Outdated Show resolved Hide resolved
packages/derive/src/lib.rs Show resolved Hide resolved
packages/derive/src/lib.rs Show resolved Hide resolved
webmaster128
webmaster128 reviewed Apr 25, 2024
View reviewed changes
Copy link
Member

@webmaster128 webmaster128 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff. Just a CHANGELOG entry missing here

@webmaster128 webmaster128 mentioned this pull request Apr 25, 2024
Closed
@aumetra aumetra merged commit ab31374 into main Apr 25, 2024
27 of 28 checks passed
@aumetra aumetra deleted the aw/set-contract-state-version branch April 25, 2024 09:58
@aumetra aumetra mentioned this pull request Apr 25, 2024
Merged
@webmaster128 webmaster128 mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webmaster128 webmaster128 webmaster128 approved these changes

@chipshort chipshort chipshort approved these changes

@kulikthebird kulikthebird Awaiting requested review from kulikthebird

Assignees
No one assigned
Labels
requested-by-gold
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Macro for setting the contract's state version in the compiled binary
3 participants
@aumetra @webmaster128 @chipshort