Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(List Converter): remove prefix/suffix capability, split, sort #1302

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Sep 21, 2024

Remove prefix/suffix : fix #702
No sort bug : fix #764
Splitting : fix #1090 #1279
Small screen UI Fix
LIst prefix/suffix bug
Sort by numeric : fix #1089

Copy link

vercel bot commented Sep 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 22, 2024 8:51am

@steffenrapp
Copy link
Contributor

Hi @sharevb I have tested it a little bit and it does what it should do! 👏🏼

But I have two findings which are also present in the original tool. Might be good to fix them:

  • There's always an empty first line in the output if you keep line breaks that wasn't there in the input. It's only "filled" if you enter a list prefix.
  • In the separator field there is a comma as placeholder which is kind of irritating. Maybe use some text instead?
Bildschirmfoto 2024-09-21 um 15 53 08

@steffenrapp
Copy link
Contributor

@sharevb according to Sonarcloud there are 4 new issues. Want to take a look at them and fix it?

@sharevb sharevb changed the title feat(List Converter): add remove prefix/suffix capability feat(List Converter): add remove prefix/suffix capability, split, sort Sep 22, 2024
@sharevb sharevb changed the title feat(List Converter): add remove prefix/suffix capability, split, sort feat(List Converter): remove prefix/suffix capability, split, sort Sep 22, 2024
Copy link

sonarcloud bot commented Sep 22, 2024

@sharevb
Copy link
Contributor Author

sharevb commented Sep 22, 2024

@sharevb according to Sonarcloud there are 4 new issues. Want to take a look at them and fix it?

HI @steffenrapp, corrected

@sharevb
Copy link
Contributor Author

sharevb commented Sep 22, 2024

But I have two findings which are also present in the original tool. Might be good to fix them:

  • There's always an empty first line in the output if you keep line breaks that wasn't there in the input. It's only "filled" if you enter a list prefix.
  • In the separator field there is a comma as placeholder which is kind of irritating. Maybe use some text instead?

Hi @steffenrapp, all those corrected, added some sorting and splitting (and better UI in small screen)

@steffenrapp
Copy link
Contributor

Hi @sharevb Looks good to me :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants