Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new tool): Smart Text Replacer and LineBreaks manager #1290

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

sharevb
Copy link
Contributor

@sharevb sharevb commented Sep 11, 2024

Smart Replacer functionality taken as base from #976 by @utf26
Fixed linebreaking display in Smart Replacer
Add linebreaking options

Fix #1279 #1194 #616 #1090

Smart Replacer functionality taken as base from CorentinTh#976 by @utf26
Fixed linebreaking display in Smart Replacer
Add linebreaking options

Fix CorentinTh#1279 CorentinTh#1194 CorentinTh#616
Copy link

vercel bot commented Sep 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
it-tools ✅ Ready (Inspect) Visit Preview Sep 21, 2024 0:07am

@steffenrapp
Copy link
Contributor

steffenrapp commented Sep 12, 2024

Hi @sharevb thanks for the tool! I did some basic testing and have a few findings:

  • You can't search for a space. I searched for " a" and it only found "a".
  • Title and description are not displayed. The texts in the English translation file are missing.
  • I'm not sure what the placeholder text in "replace with" means. Maybe needs some explanation?
Bildschirmfoto 2024-09-12 um 07 42 09

@sharevb
Copy link
Contributor Author

sharevb commented Sep 13, 2024

Hi @steffenrapp , thanks for this reporting

  • You can't search for a space. I searched for " a" and it only found "a".

=> spaces where trimmed from find regex

  • Title and description are not displayed. The texts in the English translation file are missing.

=> should be ok now

  • I'm not sure what the placeholder text in "replace with" means. Maybe needs some explanation?

=> changed to a simplier version, probably need to make a regex memo/cheatsheet

@steffenrapp
Copy link
Contributor

Hi @sharevb thanks a lot! Works a expected now 🪩

@sharevb sharevb mentioned this pull request Sep 15, 2024
@steffenrapp
Copy link
Contributor

steffenrapp commented Sep 16, 2024

Hi @sharevb I have used the tool some times and have two new things:

  • Is it possible to add a copy button to the output so it can be copied easily? EDIT: I just saw that there is a copy button but if the field is too wide then the button is outside the screen and therefore cannot be used.
  • The output field doesn't break lines if a line is too long for the box and I also cannot scroll to the side. Would be nice to either break the line in the display field or enable scrolling.

@sharevb
Copy link
Contributor Author

sharevb commented Sep 21, 2024

=

  • Is it possible to add a copy button to the output so it can be copied easily? EDIT: I just saw that there is a copy button but if the field is too wide then the button is outside the screen and therefore cannot be used.
  • The output field doesn't break lines if a line is too long for the box and I also cannot scroll to the side. Would be nice to either break the line in the display field or enable scrolling.

Hi @steffenrapp, should be ok now

@steffenrapp
Copy link
Contributor

Hi @sharevb great! Works fine now.
Just found another thing that can be optimized - sorry 😅
On the phone "match case" and "keep linebreaks" are displayed really bad. Maybe move both to a separate line?

image

@sharevb
Copy link
Contributor Author

sharevb commented Sep 21, 2024

Hi @sharevb great! Works fine now. Just found another thing that can be optimized - sorry 😅 On the phone "match case" and "keep linebreaks" are displayed really bad. Maybe move both to a separate line?

Hi @steffenrapp, héhé ;) should be ok now

Copy link

sonarcloud bot commented Sep 21, 2024

@steffenrapp
Copy link
Contributor

@sharevb Yes, perfect! 😃 Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add or remove line breaks
2 participants