Create and test fromHexString and fromBytes for SszBitlist #8611
+97
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
hey @rolfyone! is it possible to rerun ci/circleci: acceptanceTests on this pr? |
gfukushima
reviewed
Sep 20, 2024
| } | ||
|
|
||
| @Test | ||
| public void testFromHexStringEdgeCases() { |
There was a problem hiding this comment.
I think this would be even better if we break this general edge cases into individual tests?
| public SszBitlist fromBytes(final Bytes bytes) { | ||
| checkArgument(bytes != null, "Input bytes cannot be null"); | ||
| try (SszReader reader = SszReader.fromBytes(bytes)) { | ||
| TreeNode node = sszDeserializeTree(reader); |
There was a problem hiding this comment.
nit: this can use the final modifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
this PR adds 2 methods for working with SszBitlist
These methods are now available on SszBitlistSchema, so you can do
Fixed Issue(s)
Issue #8505