Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: loop counter corrected fixes #755 #756

Merged
merged 1 commit into from
Jul 5, 2023
Merged

fix: loop counter corrected fixes #755 #756

merged 1 commit into from
Jul 5, 2023

Conversation

ThomasPiellard
Copy link
Collaborator

in load_wire_commitments_commit_api, replaced the loop counter by vk_nb_commitments_commit_api (instead of 2*vk_nb_commitments_commit_api )

fixes #755

DavePearce
DavePearce approved these changes Jul 5, 2023
View reviewed changes
Copy link

@DavePearce DavePearce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yup, looks good to me

@ThomasPiellard ThomasPiellard merged commit c44845c into develop Jul 5, 2023
4 checks passed
@ThomasPiellard ThomasPiellard deleted the fix/plonk_audit_4-13 branch July 5, 2023 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DavePearce DavePearce DavePearce approved these changes

@ivokub ivokub ivokub approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ThomasPiellard @DavePearce @ivokub