feat: [PLONK_AUDIT_4-4] fixes #741 #742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DavePearce
reviewed
Jul 3, 2023
backend/plonk/bn254/solidity.go
Outdated
| // l_success := true | ||
| mstore(add(state, state_success), and(l_success,mload(add(state, state_success)))) | ||
| let res_pairing := mload(0x00) | ||
| mstore(add(state, state_success), and(l_success,eq(res_pairing,0x1))) |
There was a problem hiding this comment.
Hmmm, this doesn't seem equivalent. If state_success is false at this point (e.g. because say the quotient check failed) then you're ignoring that information? Seems to me like you need to and against mload(add(state, state_success) and res_pairing.
Also, do you really need the eq(...,0x1). The yellow paper seems to me to say that the SNARKV precompiled contract either returns 0 or 1.
There was a problem hiding this comment.
yep you're right, somehow I manage to make mistakes at each commits^^
There was a problem hiding this comment.
All good, that's what the process is for.
DavePearce
approved these changes
Jul 5, 2023
ivokub
approved these changes
Jul 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
added pairing check result: fixes #741