Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes to Synchrotron Radiation from issue #4921. Part 1. #4926

Merged
merged 6 commits into from
Jun 10, 2024

Commits on Jun 5, 2024

  1. change_parameters_randomly.py now has a main()

    as well as uses pathlib and some comment corrections
    FilipO28555 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    edea9be View commit details
    Browse the repository at this point in the history
  2. 1) subtract_functions() is now without a bug and unnecessary list tru…

    …ncation
    
    2) Changed the number of bins to 200 for better accuracy
    3) added some printouts for clarity
    FilipO28555 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    f44009a View commit details
    Browse the repository at this point in the history
  3. Abstract OpenPMD data reading for photons and electrons in validate.py

    - Introduced `read_photon_data` function to encapsulate the logic for reading and processing photon data from OpenPMD series iteration.
    - Introduced `read_electron_data` function to encapsulate the logic for reading and processing electron data from OpenPMD series iteration.
    - Refactored the `main` function to use the new abstraction functions for reading photon and electron data.
    
    This change improves code readability and maintainability by separating concerns and making the main function less complex.
    FilipO28555 committed Jun 5, 2024
    Configuration menu
    Copy the full SHA
    a231570 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    d3192d3 View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2024

  1. Added changes from comments:

     - in np.interp() added left=0 and right=0
     - subtract_functions() is now relative_error_array()
     - SystemExit changed to ValueError
    FilipO28555 committed Jun 6, 2024
    Configuration menu
    Copy the full SHA
    7780597 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2024

  1. Changed to np.mean as suggested

    and reverted the ValueError to SystemExit
    FilipO28555 committed Jun 7, 2024
    Configuration menu
    Copy the full SHA
    a45339c View commit details
    Browse the repository at this point in the history