FLYonPIC v2.0 #4551
Merged
FLYonPIC v2.0 #4551
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@PrometheusPi and @steindev for now no review required unless you really want to, a detailed examination together with @psychocoderHPC is already planned |
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
2 times, most recently
from
7efa915
to
8176990
Compare
psychocoderHPC
requested changes
May 9, 2023
include/picongpu/particles/atomicPhysics2/kernel/SpawnIonizationMacroElectrons.kernel
Outdated
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
2 times, most recently
from
0edcd5b
to
319c2e2
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
3 times, most recently
from
cd84064
to
95f2ced
Compare
include/picongpu/particles/atomicPhysics2/rateCalculation/BoundBoundTransitionRates.hpp
Outdated
Show resolved
Hide resolved
psychocoderHPC
requested changes
Jun 2, 2023
include/picongpu/particles/atomicPhysics2/initElectrons/InitElectronAs.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics2/initElectrons/InitElectronAs.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics2/initElectrons/InitElectronAs.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics2/initElectrons/InitElectronAs.hpp
Outdated
Show resolved
Hide resolved
include/picongpu/particles/atomicPhysics2/initElectrons/InitElectronAs.hpp
Outdated
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
4 times, most recently
from
027dda3
to
ba163ba
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
2 times, most recently
from
c03665b
to
028401c
Compare
include/picongpu/particles/atomicPhysics2/atomicData/BoundFreeTransitionData.hpp
Outdated
Show resolved
Hide resolved
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
3 times, most recently
from
783462a
to
57e0be8
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
8 times, most recently
from
7c5d30d
to
7591dd5
Compare
Seperate control flow loop from sub stage calls. Co-authored-by: BrianMarre <[email protected]>
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
from
ff06725
to
372f595
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
from
1f92595
to
28e8b98
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
from
28e8b98
to
d829da0
Compare
BrianMarre
force-pushed
the
topic-refactorAtomicPhysics_v2.0
branch
from
f206239
to
d8ed88a
Compare
- add traits to get, filterBy particle type - add particle type tags for easy meta template programming - add collection for attributes needed by atomicPhysics ions - rename alias `atomicPhysics_` to `atomicPhysicsParticle` Co-authored-by: BrianMarre <[email protected]>
|
I checked that 94f1aab still fulfills the atomicPhysicsCI test |
psychocoderHPC
approved these changes
Aug 15, 2024
|
@BrianMarre please add (seperate PR) the svg or source data of your big plot you added as png. The png can not be editied. |
psychocoderHPC
merged commit 8581f76
into
ComputationalRadiationPhysics:dev
9 checks passed
psychocoderHPC
added
the
changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second version of FLYonPIC
now includes:
as well as a reworked atomic rate solver with adaptive time stepping
still missing:
requires