-
Notifications
You must be signed in to change notification settings - Fork 48
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add expiration date and storage temperature fields to inventory… #2152
base: main
Are you sure you want to change the base?
Conversation
LCOV of commit
|
…nd storage temperature
lib/export/export_chemicals.rb
Outdated
@@ -4,7 +4,7 @@ module Export | |||
class ExportChemicals | |||
CHEMICAL_FIELDS = %w[ | |||
chemical_sample_id cas status vendor order_number amount price person required_date | |||
ordered_date required_by pictograms h_statements p_statements safety_sheet_link_merck | |||
ordered_date expiration_date storage_temperature required_by pictograms h_statements p_statements safety_sheet_link_merck |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Layout/LineLength: Line is too long. [127/120]
LCOV of commit
|
LCOV of commit
|
clideo_editor_c525fe1eb3f74fa2a3a60532384a07ca.mp4 |
clideo_editor_ce2afe91e4d54bb5969181507ec8ce1d.mp4 |
video1: apply changes to fields and export chemical with these fields |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everything looks fine to me.
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release