Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Wellplate change size after creation #2123

Open
wants to merge 12 commits into
base: main
Choose a base branch
from

Conversation

headri
Copy link
Contributor

@headri headri commented Sep 3, 2024

User is now able to create a wellplate without defining the size (entry: "not yet chosen").
After the creation the user can modify the wellplate to set a predefined or custom size and save it.
After the size is set, it cannot be changed again. When the size is set, the users is notified, that it cannot be changed.

@headri headri requested a review from PiTrem September 3, 2024 13:04
@PiTrem PiTrem changed the title Wellplate change size after creation feat: Wellplate change size after creation Sep 16, 2024
Copy link

LCOV of commit 92daf73 during Continuous Integration #3789

Summary coverage rate:
  lines......: 65.5% (14029 of 21428 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link
Collaborator

@JanCBrammer JanCBrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After the size is set, it cannot be changed again.

Wasn't this what this PR was supposed to implement? I.e., wasn't the goal to enable changing wellplate-size even after creation?

Copy link
Collaborator

@JanCBrammer JanCBrammer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the instructions in red are off by one? I.e., The red instructions should go away when I enter "0" or "100" ?

wellplate_dimensions

Maybe also replace 0 with 1, since 0 doesn't make a lot of sense from a user perspective.

Other than that the changes seem to be working well in the UI. However, I'm not quite sure if this PR solves the original problem, i.e., to enable changing wellplate size at any time.

Copy link

LCOV of commit a2b897d during Continuous Integration #3813

Summary coverage rate:
  lines......: 65.5% (14027 of 21428 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Copy link

LCOV of commit 63b7274 during Continuous Integration #3825

Summary coverage rate:
  lines......: 65.5% (14027 of 21428 lines)
  functions..: no data found
  branches...: no data found

Files changed coverage rate: n/a

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants