feat: spellcheck in the description texteditor #2027
Conversation
US and UK dictionaries
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| module Chemotion | ||
| class DictionaryAPI < Grape::API | ||
| resource :dictionary do | ||
| desc "amend custom dictionary" |
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
| module Chemotion | ||
| class DictionaryAPI < Grape::API | ||
| resource :dictionary do | ||
| desc "amend custom dictionary" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| desc "amend custom dictionary" | ||
| namespace :amend do | ||
| params do | ||
| requires :new_word, type: String |
There was a problem hiding this comment.
Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
| requires :new_word, type: String | ||
| end | ||
| get do | ||
| file_path = "public/typojs/custom/custom.dic" |
There was a problem hiding this comment.
Layout/SpaceAroundOperators: Operator = should be surrounded by a single space.
| requires :new_word, type: String | ||
| end | ||
| get do | ||
| file_path = "public/typojs/custom/custom.dic" |
There was a problem hiding this comment.
Layout/ExtraSpacing: Unnecessary spacing detected.
| namespace :save do | ||
| desc "admin save" | ||
| params do | ||
| requires :new_dic, type: String |
There was a problem hiding this comment.
Layout/ExtraSpacing: Unnecessary spacing detected.
| requires :new_dic, type: String | ||
| end | ||
| get do | ||
| file_path = "public/typojs/custom/custom.dic" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
| get do | ||
| file_path = "public/typojs/custom/custom.dic" | ||
| file = File.open(file_path, "w+") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
app/api/chemotion/dictionary_api.rb
Outdated
| file.close | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/BlockAlignment: end at 51, 2 is not aligned with resource :dictionary do at 5, 4.
| end | ||
| end | ||
| end | ||
| end |
There was a problem hiding this comment.
Layout/EndAlignment: end at 52, 0 is not aligned with class at 4, 2.
LCOV of commit
|
user: added AC button to the addition information on reactions
US and UK dictionaries
rather 1-story 1-commit than sub-atomic commits
commit title is meaningful => git history search
commit description is helpful => helps the reviewer to understand the changes
code is up-to-date with the latest developments of the target branch (rebased to it or whatever) => ⏩-merge for linear history is favoured
added code is linted
tests are passing (at least locally): we still have some random test failure on CI. thinking of asking spec/examples.txt to be commited
in case the changes are visible to the end-user, video or screenshots should be added to the PR => helps with user testing
testing coverage improvement is improved.
CHANGELOG : add a bullet point on top (optional: reference to github issue/PR )
parallele PR for documentation on docusaurus if the feature/fix is tagged for a release