Current shared collection refactoring changes #2016
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 5 commits
July 12, 2024 11:28
fix: count of My Collections in the ElementTag fix: collection names being disabled for own collections fix: issue with creation of ElementTag data fix: issue with update of ElementTag data
… the collection rights. Now it will only switch the sharer and shared roles when transfer of ownership is accepted
…) i.e. set the permission level to 4 for the new owner
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -29,7 +29,7 @@ class ShareCollectionAPI < Grape::API | |||
| create_or_move_collection(params[:action], from_collection, to_collection_id, params[:ui_state]) | |||
| # create_generic_elements(params, from_collection, to_collection_id) | |||
| to_collection_id = to_collection_id ? to_collection_id : from_collection&.id | |||
| create_acl_collection(user[:value], to_collection_id, params, from_collection&.label) | |||
| create_acl_collection(user[:value], to_collection_id, params) | |||
There was a problem hiding this comment.
Style/NegatedIfElseCondition: Invert the negated condition and swap the if-else branches.
TasnimMehzabin
force-pushed
the
current-shared-collection-refactoring-changes
branch
from
fccdf0e
to
cafdf8e
Compare
added 5 commits
July 12, 2024 14:28
refactor: rubocop warning
… member - blocked in FE - blocked in BE - only a user is able to delete the share collection access if the collection has been shared with the user
TasnimMehzabin
force-pushed
the
current-shared-collection-refactoring-changes
branch
from
cafdf8e
to
9ce3366
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initial fixes for element tag