Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Audio] add a separate timeout for lavalink download #6461

Open
wants to merge 1 commit into
base: V3/develop
Choose a base branch
from

Conversation

Chovin
Copy link

@Chovin Chovin commented Oct 2, 2024

Description of the changes

closes #6460
Before Lavalink had a timeout of 60 seconds to both download and startup. This adds a separate timeout for Lavalink downloading set to 3 minutes.

Have the changes in this PR been tested?

Yes. Manually tested the following, but no test cases added:

  • downloading within previous timeout (60s)
  • downloading taking more than the new timeout (3 minutes) throws a asyncio.TimeoutError and aborts
  • reloading audio / starting the bot with Lavalink already downloaded "skips" the downloading step and uses the 60 second startup timeout

@github-actions github-actions bot added the Category: Cogs - Audio This is related to the Audio cog. label Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Audio This is related to the Audio cog.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Audio] Separate timeout for lavalink downloading
1 participant