Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow tempban by ID and ban downgrade #5978

Open
wants to merge 1 commit into
base: V3/develop
Choose a base branch
from

Conversation

raidensakura
Copy link

@raidensakura raidensakura commented Feb 2, 2023

Description of the changes

  • tempban will allow banning user by ID
  • If using the command would cause a downgrade from permanent ban to temporary ban, a prompt will appear asking if command invoker wants to proceed
  • If the user is already tempbanned, a prompt will appear asking if command invoker wants to update the duration of the current tempban.
  • Prompt will be skipped if ctx.assume_yes evaluates to True

Fixes #5915

Have the changes in this PR been tested?

Yes.

Additional Notes

This is my first PR to this repo and I'm quite new to Python. Suggestions for improvement to my PR are very welcome.

@github-actions github-actions bot added the Category: Cogs - Mod This is related to the Mod cog. label Feb 2, 2023
@Zephyrkul
Copy link
Contributor

  • Prompt will be skipped if ctx.assume_yes evaluates to True

I don't think allowing tempban to be run on a schedule would be best here.

@raidensakura
Copy link
Author

I don't think allowing tempban to be run on a schedule would be best here.

I'm only implementing this based on Jack's last statement in the issue discussion, it can be raised for discussion again if needed.

I personally think it's okay to include it since prompt only appear if user is already banned anyway, my concern is that whether it should be the default choice to downgrade instead of skipping it completely.

@Jackenmen
Copy link
Member

  • Prompt will be skipped if ctx.assume_yes evaluates to True

I don't think allowing tempban to be run on a schedule would be best here.

It's not for scheduling, it's to allow for implementing a command that skips the prompt if someone prefers it that way.

@Kreusada Kreusada added the Type: Enhancement Something meant to enhance existing Red features. label Feb 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Category: Cogs - Mod This is related to the Mod cog. Type: Enhancement Something meant to enhance existing Red features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[tempban] Allow tempbans by UserID instead of Member
4 participants