Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/470 #1153

Merged
merged 10 commits into from
May 23, 2024
Merged

Fix/470 #1153

merged 10 commits into from
May 23, 2024

Conversation

GrigoreMihai
Copy link
Contributor

@GrigoreMihai GrigoreMihai commented May 20, 2024

Summary

Changed the javascript rendering in favor of php side rendering for the pro charts lock.

Updated the pop-up links.

Added small changes to keep the code DRY.

Will affect visual aspect of the product

NO

Test instructions

Check that the pro charts lock notice is working as expected when a license is expired.

Check before Pull Request is ready:

Closes https://github.com/Codeinwp/visualizer-pro/issues/470.

@GrigoreMihai GrigoreMihai marked this pull request as ready for review May 20, 2024 10:26
@pirate-bot
Copy link
Contributor

pirate-bot commented May 20, 2024

Plugin build for 187c7f6 is ready 🛎️!

@pirate-bot pirate-bot added the pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) label May 20, 2024
@GrigoreMihai GrigoreMihai added the pr-checklist-skip Allow this Pull Request to skip checklist. label May 20, 2024
@pirate-bot pirate-bot added pr-checklist-complete The Pull Request checklist is complete. (automatic label) and removed pr-checklist-incomplete The Pull Request checklist is incomplete. (automatic label) labels May 20, 2024
@GrigoreMihai GrigoreMihai requested review from preda-bogdan and removed request for preda-bogdan May 20, 2024 10:37
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code looks good, I did left a small change that I think we can make to improve this further and some small NIT's that you can decide if they are worth adding.

classes/Visualizer/Render/Library.php Show resolved Hide resolved
classes/Visualizer/Render/Library.php Outdated Show resolved Hide resolved
js/library.js Outdated Show resolved Hide resolved
@preda-bogdan
Copy link
Contributor

A small question related to this PR. Would it be too time-consuming to ensure these changes have some testing?

@GrigoreMihai GrigoreMihai requested review from preda-bogdan and removed request for preda-bogdan May 22, 2024 19:22
@preda-bogdan
Copy link
Contributor

@GrigoreMihai Can you please fix the code style, the lint is failing. Thank you!

@GrigoreMihai
Copy link
Contributor Author

@preda-bogdan I also added a test. I was also going to lint the code when pushing the test it was not ready for review when you looked.

It is all completed now, thank you for your patience!

@GrigoreMihai GrigoreMihai removed the pr-checklist-skip Allow this Pull Request to skip checklist. label May 23, 2024
@vytisbulkevicius vytisbulkevicius merged commit f131320 into development May 23, 2024
10 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/470 branch May 23, 2024 13:07
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.11.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label May 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants