-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/470 #1153
Fix/470 #1153
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The code looks good, I did left a small change that I think we can make to improve this further and some small NIT's that you can decide if they are worth adding.
A small question related to this PR. Would it be too time-consuming to ensure these changes have some testing? |
@GrigoreMihai Can you please fix the code style, the lint is failing. Thank you! |
@preda-bogdan I also added a test. I was also going to lint the code when pushing the test it was not ready for review when you looked. It is all completed now, thank you for your patience! |
🎉 This PR is included in version 3.11.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Summary
Changed the javascript rendering in favor of php side rendering for the pro charts lock.
Updated the pop-up links.
Added small changes to keep the code DRY.
Will affect visual aspect of the product
NO
Test instructions
Check that the pro charts lock notice is working as expected when a license is expired.
Check before Pull Request is ready:
Closes https://github.com/Codeinwp/visualizer-pro/issues/470.