Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: e2e tests in pro version Codeinwp/visualizer-pro#418 #1097

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

preda-bogdan
Copy link
Contributor

@preda-bogdan preda-bogdan commented Mar 20, 2024

Summary

Improved the filter conditions so that only one upsell is present for each category and that the upsell is not present when the pro plugin is active.

Added e2e tests for all upsells using the filter.

Note

Once this is merged into development the e2e tests from the PRO version should also pass.

Will affect the visual aspect of the product

NO

Screenshots

Test instructions

  1. Check that all upsells work as before.
  2. Check that the e2e pass.

Check before Pull Request is ready:

Closes Codeinwp/visualizer-pro#418.

@preda-bogdan preda-bogdan marked this pull request as ready for review March 21, 2024 11:00
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 21, 2024
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 21, 2024

Plugin build for 3152556 is ready 🛎️!

@vytisbulkevicius vytisbulkevicius merged commit cc48b80 into development Mar 22, 2024
9 checks passed
@vytisbulkevicius vytisbulkevicius deleted the fix/e2e_testing_for_pro branch March 22, 2024 14:39
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants