Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rock] Add playwright #1094

Merged
merged 15 commits into from
Mar 26, 2024
Merged

Conversation

Soare-Robert-Daniel
Copy link
Contributor

@Soare-Robert-Daniel Soare-Robert-Daniel commented Mar 13, 2024

Closes #1091

Summary

  • I added Playwright as a runner for tests;
  • Migrate the old cypress to the playwright;
    • chart creation with admin pages
    • data import
    • Gutenberg block insertion in Post
  • Introduced new tests;
    • admin filter check
    • Gutenberg block inspector check
    • chart insertion in Post with classic editor via Media
  • Added docs on how to run the tests;
  • Small improvement to the docker-composer file for the environment testing;

Note

All tests are independent. Not need to run them in a successive order

Screenshot 2024-03-14 at 17 38 56

Comparision

Previously, the E2E accumulated 13 minutes (there was a matrix formation with 3 runs: 8 min, 3 min, 2min ). Now, the test runs at 3 minutes (without the need for a matrix). Thus, a reduction of 10 minutes (~79% improvement).

Also, great performance for the tools, working with playwright editor is much better than cypress, way less lag.

Check before Pull Request is ready:

@Soare-Robert-Daniel Soare-Robert-Daniel self-assigned this Mar 13, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel linked an issue Mar 13, 2024 that may be closed by this pull request
@pirate-bot
Copy link
Contributor

pirate-bot commented Mar 13, 2024

Plugin build for acfd39a is ready 🛎️!

@Soare-Robert-Daniel Soare-Robert-Daniel added the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 14, 2024
@pirate-bot pirate-bot added the pr-checklist-complete The Pull Request checklist is complete. (automatic label) label Mar 14, 2024
@Soare-Robert-Daniel Soare-Robert-Daniel removed the pr-checklist-skip Allow this Pull Request to skip checklist. label Mar 18, 2024
Copy link
Contributor

@preda-bogdan preda-bogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left a few notes that you can maybe clear up for me, other than that the code looks good. I can approve it once you answer them.

Thank you!

.github/workflows/test-e2e.yml Outdated Show resolved Hide resolved
docker-compose.ci.yml Outdated Show resolved Hide resolved
Copy link
Contributor

@GrigoreMihai GrigoreMihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with the latest changes.

@Soare-Robert-Daniel Soare-Robert-Daniel merged commit 358c4ba into development Mar 26, 2024
7 checks passed
@Soare-Robert-Daniel Soare-Robert-Daniel deleted the dev/playwright-migration branch March 26, 2024 11:04
@pirate-bot
Copy link
Contributor

🎉 This PR is included in version 3.10.9 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@pirate-bot pirate-bot added the released Indicate that an issue has been resolved and released in a particular version of the product. label Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr-checklist-complete The Pull Request checklist is complete. (automatic label) released Indicate that an issue has been resolved and released in a particular version of the product.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[DEV][ROCK] Move the testing infra to Playwright
4 participants