updates needed for php7.2 #6
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
williamdes
reviewed
May 28, 2021
| ca-certificates curl cron git supervisor mysql-client vim unzip libxml2-dev mime-support ssmtp \ | ||
| php7.2-fpm php7.2-curl php7.2-gd php7.2-mysql php7.2-gmp php7.2-ldap php7.2-zip \ | ||
| php7.2-bcmath php-pear php-console-table php-apcu php-mongodb php-ssh2 \ | ||
| apache2 && apt-get -y --allow-unauthenticated upgrade && rm -r /var/lib/apt/lists/* |
There was a problem hiding this comment.
it would be better to install the GPG key
Probably use something like: https://gist.github.com/janus57/37b079a383dd0507149bd94fd35053d1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the repo for newer versions of php, changed everything to php7.2.
Added the line
add-apt-repository ppa:ondrej/php -y | echo 0separate because otherwise the command didn't exist and the echo 0 makes it work as it was mad that didn't return a 0. It's a bad hack.I also skipped adding php7.2-mcrypt as it wasn't downloading, not sure what it does and if it's needed.
Can be tested as the docker image
fabean/drupal:php7.2Would in Docker want to take what's currently there and tag it php7.0 then make this the tag php7.2 and once tested and working properly it can be moved to latest.