Update workflow to store and pull streetview images from GCS subdirectory #894
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
@nlebovits the "PR Checks Backend" is failing. A formatting or linting issue might be causing this. Can you take a look? Thanks! 
|
There was a problem hiding this comment.
Hi @nlebovits this PR is running into formatting or linting issues. Can you take a look?
|
@CodeWritingCow yep! on it |
| url = f"https://maps.googleapis.com/maps/api/streetview/metadata?location={quote(address)}, Philadelphia, PA&key={key}" | ||
| response = requests.get(url) | ||
| return response.json() | ||
| url = f"http://example.com/metadata/{address}" |
There was a problem hiding this comment.
This looks like an incorrect url, it used to be maps.googleapis.com
| metadata = get_streetview_metadata(row["address"]) | ||
| upload_image_with_metadata(blob, image_content, metadata) | ||
| # Check if file already exists | ||
| if not blob.exists(): |
There was a problem hiding this comment.
This is contrary to comment above.
|
|
||
|
|
||
| # Function to retry failed addresses until all succeed | ||
| def retry_failed_addresses(): |
|
|
||
|
|
||
| # Retry failed addresses sequentially until | ||
| def process_failed_addresses_sequentially(): |
|
@zigouras thanks for the review. there are a number of errors in the code--I took a break from working on it on Thursday but expect to get back to it this week. |
nlebovits
force-pushed
the
lebovits/issu717-store-streetview-imgs-in-subdirectory
branch
from
f168877
to
c5092c6
Compare
|
@CodeWritingCow can you review the front end pieces of this commit and lmk if you see where my code is going wrong and what I can fix. No worries if not--I need to put more time into this one. |
To better organize GCS, this PR adds a subdirectory in which to store streerview images, and also updates the front end to pull the images correctly from that directory. Addresses #717 .