Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SENTRY_ENVIRONMENT #732

Merged
merged 4 commits into from
Jun 22, 2024
Merged

SENTRY_ENVIRONMENT #732

merged 4 commits into from
Jun 22, 2024

Conversation

kilemensi
Copy link
Member

Description

Seems like we've been using SENTRY_ENV wrong; It should be SENTRY_ENVIRONMENT. This PR fixes that. In addition:

  • Remove the use of relative imports (import x from ../../) and prefer alias (import x from @/roboshield/). We absolutely need to update our typescript eslint config to include this
  • Fixes Props issue on Page (first I'm using export type! Seems like we can declare Props in one and only one place and import it anywhere we need).

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Screenshots

N/A

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@kilemensi kilemensi added the chore A task that needs to be done (neither enhancement or bug) label Jun 22, 2024
@kilemensi kilemensi self-assigned this Jun 22, 2024
Copy link
Contributor

Latest updated Preview URL

Name Review
codeforafrica-ui-pr-732 Visit

@kilemensi kilemensi merged commit b91c396 into main Jun 22, 2024
6 checks passed
@kilemensi kilemensi deleted the fix/ui_sentry_environment_name branch June 22, 2024 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore A task that needs to be done (neither enhancement or bug)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant