Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve RoboShield Hero & Footer #731

Merged
merged 7 commits into from
Jun 22, 2024
Merged

Conversation

kilemensi
Copy link
Member

Description

Hero

  • Move to rows of title instead of a single row since the red text doesn't align well with call to action button
  • User theme defined colours wherever possible
  • Improve component spacing
  • Fix mobile issues

Footer

  • Looks a bit "empty". Include Newsletter subscription and Stay in touch for the time being until we figure out what else needs to be added
  • Improve component spacing and alignment (including spellchecking)
  • Fix mobile issues

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Screenshots

Desktop

d

Mobile

m

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

Probably caused by weird merge
This is because it looks a bit plain without them
+ Use primary.main for background colour
+ Stack titles to have better alignment
@kilemensi kilemensi added bug Something isn't working enhancement New feature or request labels Jun 22, 2024
@kilemensi kilemensi self-assigned this Jun 22, 2024
@kilemensi kilemensi merged commit f6e1414 into main Jun 22, 2024
4 checks passed
@kilemensi kilemensi deleted the feat/roboshield_general_ui branch June 22, 2024 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant