Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display all Tools #726

Merged
merged 11 commits into from
Jul 3, 2024
Merged

Display all Tools #726

merged 11 commits into from
Jul 3, 2024

Conversation

koechkevin
Copy link
Contributor

Description

There's a need to display all the tools even if external ID is missing.

Fixes # (issue)

Type of change

  • New feature (non-breaking change which adds functionality)

Screenshots

image

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation

@koechkevin koechkevin requested a review from a team June 21, 2024 09:45
@koechkevin koechkevin self-assigned this Jun 21, 2024
Copy link
Member

@kilemensi kilemensi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍🏽


Can you may be describe the approach we've taken? e.g. yes, we don't fetch the tools but will they still have associated contributors or organisations if this information is provided in the Airtable?

@koechkevin
Copy link
Contributor Author

👍🏽

Can you may be describe the approach we've taken? e.g. yes, we don't fetch the tools but will they still have associated contributors or organisations if this information is provided in the Airtable?

@kilemensi tools are a source of truth.
We do not process any contributor/organisation without tools. Since we initially did not process any tool without external ID, we only needed to reverse that and ensure we do not try to query from github if external ID does not exist.

@kilemensi
Copy link
Member

I think I get you @koechkevin but to confirm:

  1. Everything starts with tools
  2. We currently don't process any tool without externalId (GitHub)

This PR changes this

  1. We directly show information about tools without externalId (point 2)

My immediate questions:

  1. Does this mean we also show contributors/organisations using information directly obtained from Airtable or do we stop at tools only?
  2. Do we show all tools without externalIds or do we at least ensure certain minimum information is present before displaying e.g. if I've only include tool name without description, logo, etc., will that show up on the site?

@koechkevin
Copy link
Contributor Author

I think I get you @koechkevin but to confirm:

  1. Everything starts with tools
  2. We currently don't process any tool without externalId (GitHub)

This PR changes this

  1. We directly show information about tools without externalId (point 2)

My immediate questions:

  1. Does this mean we also show contributors/organisations using information directly obtained from Airtable or do we stop at tools only?
  2. Do we show all tools without externalIds or do we at least ensure certain minimum information is present before displaying e.g. if I've only include tool name without description, logo, etc., will that show up on the site?
  1. We stop at tools only.
  2. At the moment we ensure only the name is present. We could as well include the image.

@kilemensi
Copy link
Member

Cool @koechkevin

  1. Lets create an issue for us to consider organisations and contributors.
  2. Lets include a bit more, otherwise the page will be quite empty: name, description, country, logo/image and theme? I'd also like to say at least a single partner or supporter but you can discuss that with Sarah/Eric if it's a good idea or no.

@koechkevin koechkevin added this pull request to the merge queue Jul 3, 2024
Merged via the queue into main with commit 1f52ad2 Jul 3, 2024
4 checks passed
@koechkevin koechkevin deleted the feature/display-all-tools branch July 3, 2024 07:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants