Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error uploading offset datetime #263

Merged
merged 2 commits into from
Aug 20, 2024
Merged

Fix error uploading offset datetime #263

merged 2 commits into from
Aug 20, 2024

Commits on Aug 20, 2024

  1. Fix error uploading offset datetime 

    ### Description

Without this change Metabase will throw the following error when uploading a CSV with a datetime with an offset value:

```
class java.time.OffsetDateTime` cannot be cast to class `java.lang.String`
```

This is because we were missing a case in the insert method, and it was falling through the the catch all case. The first fix is to add an explicit case for this type to fix the JDBC integration.

The second fix is to update the config for how we map CSV columns to database types in particular. Since Clickhouse does not preserve the input offset, we made the product choice to keep these values as their raw input string. By returning `nil` for this type we can trigger this behavior.
    @crisptrutski
    crisptrutski committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    6d706f3 View commit details
    Browse the repository at this point in the history

  2. Fix fall through case

    @crisptrutski
    crisptrutski committed Aug 20, 2024
    Configuration menu
    Copy the full SHA
    dda9967 View commit details
    Browse the repository at this point in the history