Gun-shy

[Consoleable]

Summary

Content "Adds Gun-shy Trait"

Purpose of change

Adds a gun-shy trait to character gen. Allows bows and the like but not firearms.

Describe the solution

adds gunshy trait, prevents user from firing guns and turret guns, similar functionality to brawler. Allows user to fire primitive ranged weapons like crossbows and bows.

Describe alternatives you've considered

Not adding the trait.

Testing

Tested crossbows with and without
Tested bow with and without
Tested glock 17 with and without
Tested firing mode of m16
Tested trying to fire m249 with and without
Tested firing double barrel shotgun with and without
Tested firing mp 40 with and without
Tested firing 3 inch ordinance rifle with and without
Teated firing staff sling with and without

Guns and ordinance cannot be fired, even if turret
Bows and crossbows and anything with "primitive_ranged_weapon" is allowed as per is_firearm()

I havent tested every gun but i did one in each category i think its ready for integration.

Additional context

[TheShadowFerret]

Since Gunshy encompasses what Brawler does + more, selecting both shouldn't be possible(esp. for people using legacy point select, since that's double points).

[Consoleable]

Since Gunshy encompasses what Brawler does + more, selecting both shouldn't be possible(esp. for people using legacy point select, since that's double points).

This is an excellent suggestion, dunno why i missed that!

[XygenSS]

Can you use rail mounted crossbows attached on a firearm?

[Consoleable]

Can you use rail mounted crossbows attached on a firearm?

Will test this after work, most likely not though, still a WIP.
May have to add support in an additional update depending on how much work it would be to add.
Good suggestion!

[Aimless-dude]

Will you still be able to use the crossbow turret, the Carroballista?

[Consoleable]

Will you still be able to use the crossbow turret, the Carroballista?

The intention is yes, and the ballista does have Primitive_Ranged_weapon, so if it's not compatible it should be easy to patch.

Can you use rail mounted crossbows attached on a firearm?

This may not happen for some time as I think, as the weapon that the rail mounted crossbow is on would most likely be a firearm. Using it on a non-firearm with some kind it should still work though. The item is a gun mod, so the gun properties would be inherited from the base item.

[Consoleable]

Will you still be able to use the crossbow turret, the Carroballista?

I've been looking into this, and it looks like it's a bit of a challenge to set up. I'm going to make an issue for this and handle it in a followup PR, because addressing this will require changing some more things in turrret.cpp and i don't want to scope creep
The ballistae isn't commonly used or easy to find, so i'll merge this version of the trait for now.