Support for BGP confederations in AS_PATH for IOS-XR #620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasMcClelland
approved these changes
Mar 11, 2022
|
Thanks for contributing! |
lsheikal
approved these changes
Apr 18, 2022
|
Can you merge this please? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added parenthesis within regexes in which the code is trying to parse AS_PATH. Changes were performed in iosxr/show_bgp.py for classes ShowBgpInstanceNeighborsReceivedRoutes, ShowBgpInstanceNeighborsAdvertisedRoutes and ShowBgpInstanceAllAll.
Also fixed show ShowBgpInstanceAllAll not matching IPv6 prefixes with p16 and as a result their paths/nexthops were added as indexes to the previous prefix of p16_1.
Motivation and Context
To parse BGP confederation paths. I wanted to use the learn bgp feature for an upcoming migration from XE to XR but most of the table was missing.
Impact (If any)
Screenshots:
Checklist: