Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added VyOS #47

Merged
merged 1 commit into from
Sep 23, 2024
Merged

Added VyOS #47

merged 1 commit into from
Sep 23, 2024

Conversation

conceptual-perception
Copy link
Contributor

I read and tried to follow the contributing guidelines.

I added VyOS. I'm active on the Cisco Study Group Discord.

Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting! We love new contributors. I had a few somewhat small comments, and an ask for a bit more CML user-friendly docs on the qcow2 creation bit.

node-definitions/vyos/VyOS-Router.yaml Outdated Show resolved Hide resolved
node-definitions/vyos/VyOS-Router.yaml Outdated Show resolved Hide resolved
loopback:
- lo
ui:
visible: false
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why false? This should be true.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

modified on my fork

virl-base-images/vyos/readme.md Outdated Show resolved Hide resolved
id: VyOS-Router
general:
nature: router
description: Opensource Router and Firewall Platform
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be good to use |- and include a bit more details such as a link to the VyOS docs.

@conceptual-perception
Copy link
Contributor Author

I'm still learning git. I nuked what I was doing on accident trying to squash. I'll figure it out and try again.

@conceptual-perception
Copy link
Contributor Author

The above should be resolved. It was very messy -- I had to ask a colleague to help find the disconnected commits.

++ node-definition/vyos/README.md
++ node-definition/vyos/VyOS-Router.yaml
++ virl-base-images/vyos/VyOS-1.5-rolling-XXX
++ virl-base-images/vyos/proxmox-instructions.md
++ virl-base-images/vyos/virt-install-instructions.md
Copy link
Collaborator

@xorrkaz xorrkaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@xorrkaz
Copy link
Collaborator

xorrkaz commented Sep 23, 2024

Thanks! Great work.

@xorrkaz xorrkaz merged commit 6095458 into CiscoDevNet:master Sep 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants