Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ISN Fabric Support for dcnm_fabric module. #322

Merged
merged 5 commits into from
Sep 30, 2024
Merged

ISN Fabric Support for dcnm_fabric module. #322

merged 5 commits into from
Sep 30, 2024

Conversation

allenrobel
Copy link
Collaborator

@allenrobel allenrobel commented Aug 31, 2024

Summary

This PR, when merged, provides support for the ISN (Inter-Site Network) fabric type (also known as Multi-Site External Network).

Branch

fabric_isn created off of branch develop

CODE FUNCTIONAL CHANGES

plugins/module_utils/fabric/fabric_types.py
- Add changes for ISN fabric

DOCUMENTATION

  • dcnm_fabric.py

    • Update DOCUMENTATION section to include parameters for ISN fabric type.
  • docs/cisco.dcnm.dcnm_fabric_module.rst

    • Update with parameters for ISN fabric type.
  • docs/cisco.dcnm.dcnm_maintenance_mode_module.rst

    • This was missing. Adding it as part of this commit.
  • README.md

    • Add dcnm_maintenance_mode link

INTEGRATION TESTS

  • playbooks/roles/dcnm_fabric/dcnm_tests.yaml

    • Added IT for ISM delete, merged, replaced
  • tests/integration/targets/dcnm_fabric/tests/*.yaml

    • Added the following tests - dcnm_fabric_deleted_basic_isn.yaml - dcnm_fabric_merged_baeic_isn.yaml
  • Modified the following tests (tests were modified to include ISN)

    • dcnm_fabric_deleted_basic.yaml
  • Modified the following tests (only comments are modified)

    • dcnm_fabric_deleted_basic_ipfm.yaml
    • dcnm_fabric_deleted_basic_lan_classic.yaml
    • dcnm_fabric_deleted_basic_vxlan.yaml

UNIT TESTS

  • tests/unit/modules/dcnm/dcnm_fabric/test_fabric_types.py
    • Updated all tests to include ISN fabric type

CODE FUNCTIONAL CHANGES

plugins/module_utils/fabric/fabric_types.py
    - Add changes for ISN fabric

DOCUMENTATION

dcnm_fabric.py
   - Update documentation to include ISN fabric type

docs/cisco.dcnm.dcnm_fabric_module.rst
   - Update with ISN fabric type

docs/cisco.dcnm.dcnm_maintenance_mode_module.rst
   - This was missing.  Adding it as part of this commit...

README.md
    - Add dcnm_maintenance_mode link

INTEGRATION TESTS

playbooks/roles/dcnm_fabric/dcnm_tests.yaml
   - Added IT for ISM delete, merged, replaced

tests/integration/targets/dcnm_fabric/tests/*.yaml
     - Added the following tests
        - dcnm_fabric_deleted_basic_isn.yaml
        - dcnm_fabric_merged_baeic_isn.yaml

    - Modified the following tests (tests were modified to include ISN)
        - dcnm_fabric_deleted_basic.yaml

    - Modified the following tests (only comments are modified)
        - dcnm_fabric_deleted_basic_ipfm.yaml
        - dcnm_fabric_deleted_basic_lan_classic.yaml
        - dcnm_fabric_deleted_basic_vxlan.yaml
Fix sanity test errors.  NETFLOW_*_LIST parameters needed "elements: str"
@allenrobel allenrobel changed the title ISN Fabric Support for dcnm_fabric module. WIP. ISN Fabric Support for dcnm_fabric module. Ready for review. Aug 31, 2024
@allenrobel allenrobel linked an issue Aug 31, 2024 that may be closed by this pull request
@allenrobel allenrobel self-assigned this Aug 31, 2024
@allenrobel allenrobel added the ready for review PR is ready to be reviewed label Sep 5, 2024
@allenrobel allenrobel changed the title ISN Fabric Support for dcnm_fabric module. Ready for review. ISN Fabric Support for dcnm_fabric module. Sep 5, 2024
@mikewiebe mikewiebe merged commit 96dc4a6 into develop Sep 30, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready for review PR is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

support external fabric in the dcnm_fabric module
2 participants