MDL-77639 gradebook_setup: Create outcomes via dyn form

Chocolate-lightning · Jun 30, 2023 · af6d520 · af6d520
1 parent 267203e
commit af6d520
Show file tree

Hide file tree

Showing 9 changed files with 537 additions and 23 deletions.
diff --git a/admin/tool/behat/tests/behat/data_generators.feature b/admin/tool/behat/tests/behat/data_generators.feature
@@ -412,8 +412,8 @@ Feature: Set up contextual data for tests
     Then I should see "Test Outcome Grade Item 1"
     And I click on grade item menu "Test Outcome Grade Item 1" of type "gradeitem" on "setup" page
     And I choose "Edit grade item" in the open action menu
+    And I click on "Show more..." "link" in the "Edit outcome item" "dialogue"
     And the field "Outcome" matches value "Grade outcome 1"
-    And I expand all fieldsets
     And I should see "Grade category 1" in the "Grade category" "form_row"
     And I press "Cancel"
 

diff --git a/grade/amd/build/gradebooksetup_forms.min.js b/grade/amd/build/gradebooksetup_forms.min.js
diff --git a/grade/amd/build/gradebooksetup_forms.min.js.map b/grade/amd/build/gradebooksetup_forms.min.js.map
diff --git a/grade/amd/src/gradebooksetup_forms.js b/grade/amd/src/gradebooksetup_forms.js
@@ -50,6 +50,13 @@ export const init = () => {
             title = trigger.getAttribute('data-category') === '-1' ?
                 getString('newcategory', 'core_grades') : getString('categoryedit', 'core_grades');
             args.category = trigger.getAttribute('data-category');
+        } else if (event.target.closest('[data-trigger="add-outcome-form"]')) {
+            event.preventDefault();
+            trigger = event.target.closest('[data-trigger="add-outcome-form"]');
+            formClass = 'core_grades\\form\\add_outcome';
+            title = trigger.getAttribute('data-itemid') === '-1' ?
+                getString('newitem', 'core_grades') : getString('outcomeitemsedit', 'core_grades');
+            args.itemid = trigger.getAttribute('data-itemid');
         }
 
         if (trigger) {