3 fails left still but check infra

Chocolate-lightning · Jul 29, 2024 · 28abc7c · 28abc7c
1 parent 4dca508
commit 28abc7c
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 5 deletions.
diff --git a/lib/form/amd/build/form.min.js.map b/lib/form/amd/build/form.min.js.map
diff --git a/lib/form/amd/src/form.js b/lib/form/amd/src/form.js
@@ -112,6 +112,7 @@ export default class Form {
      * Add event listeners to the form.
      */
     registerEventListeners() {
+        // TODO: Choice dropdown does not trigger here.
         this.form.addEventListener('change', async(e) => {
             if (e.target.type === 'submit') {
                 FormChangeChecker.resetFormDirtyState(this.form);

diff --git a/lib/form/amd/src/form/display.js b/lib/form/amd/src/form/display.js
@@ -120,7 +120,6 @@ export const hide = (element) => {
  */
 export const show = (element) => {
     if (element !== null && !(element instanceof RadioNodeList)) {
-
         element.removeAttribute('disabled');
         const parent = element.closest('.fitem');
         if (parent) {

diff --git a/lib/form/tests/behat/fixtures/form_rules.php b/lib/form/tests/behat/fixtures/form_rules.php
@@ -96,6 +96,7 @@ public function definition() {
         $mform->disabledIf('eq_ckb_btn', 'eq_ckb', 'eq' , '1');
 
         $mform->addElement('button', 'neq_ckb_btn', 'NEQ ckb 0 hidden');
+        $mform->setDefault('neq_ckb', 1);
         $mform->hideIf('neq_ckb_btn', 'neq_ckb', 'neq' , '0');
 
         // Select test.

diff --git a/lib/form/tests/behat/form_rules.feature b/lib/form/tests/behat/form_rules.feature
@@ -24,10 +24,10 @@ Feature: Test the form rules
       | Not checked hide    | not see   | disabled      | Not checked hidden        | see          | enabled       | button      | Not checked hidden   |
       | Not checked disable | see       | disabled      | Not checked disabled      | see          | enabled       | button      | Not checked disabled |
       | EQ Checked          | see       | enabled       | EQ ckb 1 disabled         | see          | disabled      | button      | EQ ckb 1 disabled    |
-      | NEQ Checked         | see       | enabled       | NEQ ckb 0 hidden          | not see      | disabled      | button      | NEQ ckb 0 hidden     |
-#      | ds_enb              | see       | enabled       | Date selector for testing | see          | disabled      | css_element | #id_ds_day           |
+      | NEQ Checked         | not see   | disabled      | NEQ ckb 0 hidden          | see          | enabled       | button      | NEQ ckb 0 hidden     |
+      | ds_enb              | see       | enabled       | Date selector for testing | see          | disabled      | css_element | #id_ds_day           |
       | ds_dis              | see       | enabled       | Date selector for testing | not see      | disabled      | css_element | #id_ds_day           |
-      | edt_enb             | see       | enabled       | Editor for testing        | see          | enabled       | css_element | #id_edt              |
+      | edt_enb             | see       | enabled       | Editor for testing        | see          | disabled      | css_element | #id_edt              |
       | edt_dis             | see       | enabled       | Editor for testing        | not see      | disabled      | css_element | #id_edt              |
       | fp_dis              | see       | enabled       | Filepicker for testing    | not see      | disabled      | css_element | #id_fp               |