Impl EthGetTransactionByHashLimited

[sudo-shashank]

Summary of changes

Changes introduced in this pull request:

• Impl Filecoin.EthGetTransactionByHashLimited and add test

| RPC Method                                | Forest | Lotus |
|-------------------------------------------|--------|-------|
| Filecoin.EthGetTransactionByHashLimited   | Valid  | Valid |

Reference issue to close (if applicable)

Closes #4703

Other information and links

Change checklist

• I have performed a self-review of my own code,
• I have made corresponding changes to the documentation. All new code adheres to the team's documentation standards,
• I have added tests that prove my fix is effective or that my feature works (if possible),
• I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

[elmattic]

Why did you choose an Option<ChainEpoch> and not just a ChainEpoch?

[sudo-shashank]

because look_back_limit is of type Option<i64> in search_for_message

forest_filecoin::state_manager::StateManager
impl<DB> StateManager<DB>
pub async fn search_for_message(self: &Arc<Self>, from: Option<Arc<Tipset>>, msg_cid: Cid, look_back_limit: Option<i64>, allow_replaced: Option<bool>) -> Result<Option<(Arc<Tipset>, Receipt)>, Error>
where
    // Bounds from impl:
    DB: Blockstore + Send + Sync + 'static,

[elmattic]

Then let's add another test that checks the case where chain epoch is None.

[sudo-shashank]

None is tested by EthGetTransactionByHash https://github.com/ChainSafe/forest/pull/4774/files#r1766769807

[elmattic]

You're speaking of testing get_eth_transaction_by_hash function which I think is not the same.

Adding the test:

            tests.push(RpcTest::identity(EthGetTransactionByHashLimited::request(
                (tx.hash.clone(), None),
            )?));

results in:

./forest-tool api compare --lotus /ip4/127.0.0.1/tcp/1234/http --forest /ip4/127.0.0.1/tcp/2345/http forest_snapshot_calibnet_2024-09-10_height_1954295.forest.car.zst --filter EthGetTransactionByHashLimited
| RPC Method                                  | Forest            | Lotus |
|---------------------------------------------|-------------------|-------|
| Filecoin.EthGetTransactionByHashLimited (4) | CustomCheckFailed | Valid |
| Filecoin.EthGetTransactionByHashLimited (8) | Valid             | Valid |
Error: Some tests failed

[ruseinov]

yeah, I guess we need a test that has None epoch passed, as previously mentioned by @elmattic.

[sudo-shashank]

for EthGetTransactionByHash we use None

get_eth_transaction_by_hash(ctx, tx_hash, None).await

and for EthGetTransactionByHashLimited we use

get_eth_transaction_by_hash(ctx, tx_hash, limit).await

[ruseinov]

The CI needs to be green, then we're ready to rumble.