Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: demote safe eth methods to basic tests #4770

Merged
merged 1 commit into from
Sep 13, 2024
Merged

Conversation

LesnyRumcajs
Copy link
Member

Summary of changes

Changes introduced in this pull request:

  • we have no means of ensuring two nodes are completely in sync with regards to the chain head. As such, we can't, with the current setup, check for parity of methods relying on that.

Reference issue to close (if applicable)

Closes #4661

Other information and links

Change checklist

  • I have performed a self-review of my own code,
  • I have made corresponding changes to the documentation,
  • I have added tests that prove my fix is effective or that my feature works (if possible),
  • I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

@LesnyRumcajs LesnyRumcajs requested a review from a team as a code owner September 13, 2024 10:52
@LesnyRumcajs LesnyRumcajs requested review from ruseinov and hanabi1224 and removed request for a team September 13, 2024 10:52
@LesnyRumcajs LesnyRumcajs added this pull request to the merge queue Sep 13, 2024
Merged via the queue into main with commit edac9ca Sep 13, 2024
30 checks passed
@LesnyRumcajs LesnyRumcajs deleted the fix-eth-block-tests branch September 13, 2024 11:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix EthGetBlockByNumber implementation or tests
3 participants