fix: split osc packets #928
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ronag
commented
Mar 13, 2018
| ::osc::OutboundPacketStream o(reinterpret_cast<char*>(buffer_.data()), | ||
| static_cast<unsigned long>(buffer_.size())); | ||
| // TODO: Should use server clock. | ||
| time_++; |
ronag
force-pushed
the
fix-osc-split-packets
branch
from
eebfc2b
to
09e2997
Compare
ronag
commented
Mar 13, 2018
| @@ -126,13 +132,33 @@ struct client::impl : public spl::enable_shared_from_this<client::impl> | |||
| } | |||
|
|
|||
| o << ::osc::EndMessage; | |||
|
|
|||
| if (o.Size() >= 1024) { | |||
There was a problem hiding this comment.
Limit is 1500 bytes... this an approximation.
|
Helges 2.1 implementation actually did this mostly correctly. It was just very complicated and we need to provide a time tag for each split bundle. |
|
@ronag Are you working on this PR or can it be closed? |
ronag
force-pushed
the
master
branch
2 times, most recently
from
2b0c540
to
8ec45a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I don't have time to do this properly. Hoping someone can take over finish up and test.
It should be good enough. Although room for improvement. But it needs test.