-
Notifications
You must be signed in to change notification settings - Fork 471
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DS-Chat comparison #538
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good overall! Just left some comments on parts I looked closely at and didn't quite understand
@cat-state I'm happy to merge this today if there are no other changes from your side |
Yup, I don't have any changes on my side |
This PR optimizes the implementation of NeMo-PPO, adding hydra and bug fixes.