Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding 2022 Commander decks to be purchased in the Quest shop #5961

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Sunnovah
Copy link
Contributor

No description provided.

Credits=5000
MinDifficulty=0
MaxDifficulty=5
[metadata]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea if we already have these files, then we should just have a list of directories of where to pull them from.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They are in commanderprecons. I can just add the cost block to everything in there as long as the line in forge/forge-gui/src/main/java/forge/localinstance/properties/ForgeConstants.java):

public static final String QUEST_PRECON_DIR = QUEST_DIR + "precons" + PATH_SEPARATOR;

Can be coded to read from both directories.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we might
but wouldn't it be better to only use them when quest is commander mode too? 🤔

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, depends if there are any useful cards in the precons. Isn't there a commander plane in the regular quest mode as well?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There isn't but people might want to buy the precons for specific cards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants