Update cardstates after creating token from prototype #5676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
i think it should be easier to fix the Token Creation about that "OriginalHost" for such case means the Created Token, and not the Token Prototype probably in between: |
tool4ever
changed the title
Hanmac
reviewed
Jul 23, 2024
Hanmac
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts the previous cleanup.
@Hanmac
The problem is when the final token gets created from its prototype the traits that get copied over will have that original CardState instead.
Since this seems to be a bigger flaw in the engine related to #143 I probably can't do anything else here 🤔
Closes #5677