Front and End Matter Updates #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarionBWeinzierl
approved these changes
Jun 24, 2024
Co-authored-by: Marion <[email protected]>
jatkinson1000
added a commit
that referenced
this pull request
Jul 23, 2024
* add slide on naming standards * add warning about the use of f strings in logging statements * Adding instructions for naming part of exercise. * changing some of the naming in the final version of precipitation_climatology.py and making some suggestions for other possible naming changes. Removed use of assert and slight refactor to the convert_pr_units function to add an explaining variable. * hopefully made more readable * naming tweeks * revert changes to pluralise name for array. Not sure what best practice is here. t Please enter the commit message for your changes. Lines starting * add a line about boolean naming * add a line about boolean naming * formatting * Update exercises/00_final/precipitation_climatology.py Co-authored-by: jatkinson1000 <[email protected]> * fix excpetion raising bug introduced in this branch * grammar in slide. Co-authored-by: jatkinson1000 <[email protected]> * pull naming into it's own section * return matplotlib import to the standard plt and add small fix * further renaming and some additional documentation * further renaming * further naming changes * further naming changes * revert naming of columns in the netcdf as editing netcdf file is too lengthy for this iteration * remove comment as have confirmed that this hasn't introduced a runtime error * add some examples into the slides * add to example slide * finish renaming in exercise 5 * renumber exercises * include the naming slides in the main quarto file * add base code for exercise on naming * update naming in exercise 4 * update exercise 4 for renaming * run black in all the exercises after black * modified the wrong exercise * missed file naming * renumber exercises in slides and a dd a bit of extra detail * reformatting and splitting black and pylint sections * Update exercises 1 and 2 with blank lines to match changes to later exercises (blank lines not picked up by black). * remove redundant use of xr.DataArray wrapping around array multiplication * change font size in slides * remove remaining uses of assert in production code * formatting changes to slides on naming * Minor typographical updates. * remove old naming convention slide from 'better coding' slides. --------- Co-authored-by: Amy Pike <[email protected]> Co-authored-by: AmyOctoCat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1
Adds Amy and Marion as authors, removes personal info
Adds section on code clinics at the end
Fixes broken/inappropriate links and images