Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add section on variable naming #7

Merged
merged 45 commits into from
Jul 3, 2024
Merged

Add section on variable naming #7

merged 45 commits into from
Jul 3, 2024
+1,174 −694

Commits on Jun 18, 2024

  1. refactor slides to break into separate sections.

    @jatkinson1000
    jatkinson1000 committed Jun 18, 2024
    Configuration menu
    Copy the full SHA
    9b9e204 View commit details
    Browse the repository at this point in the history

Commits on Jun 19, 2024

  1. add slide on naming standards

    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    9ec93cf View commit details
    Browse the repository at this point in the history

  2. add warning about the use of f strings in logging statements

    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    4fb12be View commit details
    Browse the repository at this point in the history

  3. Adding instructions for naming part of exercise.

    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    1c2418f View commit details
    Browse the repository at this point in the history

  4. changing some of the naming in the final version of precipitation_cli… 

    …matology.py and making some suggestions for other possible naming changes. Removed use of assert and slight refactor to the convert_pr_units function to add an explaining variable.
    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    7d7aed6 View commit details
    Browse the repository at this point in the history

  5. hopefully made more readable

    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    a07e7c4 View commit details
    Browse the repository at this point in the history

  6. naming tweeks

    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    d273ee7 View commit details
    Browse the repository at this point in the history

  7. revert changes to pluralise name for array. Not sure what best practi… 

    …ce is here.

t Please enter the commit message for your changes. Lines starting
    @AmyOctoCat
    AmyOctoCat committed Jun 19, 2024
    Configuration menu
    Copy the full SHA
    8383480 View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2024

  1. add a line about boolean naming

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    99042f7 View commit details
    Browse the repository at this point in the history

  2. add a line about boolean naming

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    1083b88 View commit details
    Browse the repository at this point in the history

  3. formatting

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3ef0967 View commit details
    Browse the repository at this point in the history

  4. Update exercises/00_final/precipitation_climatology.py 

    Co-authored-by: jatkinson1000 <[email protected]>
    @AmyOctoCat @jatkinson1000
    AmyOctoCat and jatkinson1000 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    9652abe View commit details
    Browse the repository at this point in the history

  5. fix excpetion raising bug introduced in this branch

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    c37087c View commit details
    Browse the repository at this point in the history

  6. Merge branch 'add_section_on_variable_naming' of github.com:Cambridge… 

    …-ICCS/rse-skills-python into add_section_on_variable_naming
    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    97cd877 View commit details
    Browse the repository at this point in the history

  7. grammar in slide. 

    Co-authored-by: jatkinson1000 <[email protected]>
    @AmyOctoCat @jatkinson1000
    AmyOctoCat and jatkinson1000 committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6752f63 View commit details
    Browse the repository at this point in the history

  8. pull naming into it's own section

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    3c87e6f View commit details
    Browse the repository at this point in the history

  9. resolve merge conflict

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    e88749e View commit details
    Browse the repository at this point in the history

  10. return matplotlib import to the standard plt and add small fix

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    2d2ace5 View commit details
    Browse the repository at this point in the history

  11. fix merge conflicts

    @AmyOctoCat
    AmyOctoCat committed Jun 20, 2024
    Configuration menu
    Copy the full SHA
    6a8fdb0 View commit details
    Browse the repository at this point in the history

Commits on Jun 26, 2024

  1. further renaming and some additional documentation

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    694c8fe View commit details
    Browse the repository at this point in the history

  2. further renaming

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    fa01f3b View commit details
    Browse the repository at this point in the history

  3. further naming changes

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    93caff0 View commit details
    Browse the repository at this point in the history

  4. further naming changes

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e4c2fd5 View commit details
    Browse the repository at this point in the history

  5. revert naming of columns in the netcdf as editing netcdf file is too … 

    …lengthy for this iteration
    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    09c52cc View commit details
    Browse the repository at this point in the history

  6. remove comment as have confirmed that this hasn't introduced a runtim… 

    …e error
    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    67cb57e View commit details
    Browse the repository at this point in the history

  7. add some examples into the slides

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    a55b60c View commit details
    Browse the repository at this point in the history

  8. add to example slide

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    b60049f View commit details
    Browse the repository at this point in the history

  9. finish renaming in exercise 5

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    471dfec View commit details
    Browse the repository at this point in the history

  10. renumber exercises

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    40c5912 View commit details
    Browse the repository at this point in the history

  11. include the naming slides in the main quarto file

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c4e37c6 View commit details
    Browse the repository at this point in the history

  12. add base code for exercise on naming

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    7b694b1 View commit details
    Browse the repository at this point in the history

  13. update naming in exercise 4

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    6710ba1 View commit details
    Browse the repository at this point in the history

  14. update exercise 4 for renaming

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    e6168aa View commit details
    Browse the repository at this point in the history

  15. run black in all the exercises after black

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    0fc9ec8 View commit details
    Browse the repository at this point in the history

  16. modified the wrong exercise

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    f6ef57b View commit details
    Browse the repository at this point in the history

  17. missed file naming

    @AmyOctoCat
    AmyOctoCat committed Jun 26, 2024
    Configuration menu
    Copy the full SHA
    c71c31b View commit details
    Browse the repository at this point in the history

Commits on Jun 27, 2024

  1. renumber exercises in slides and a dd a bit of extra detail

    @AmyOctoCat
    AmyOctoCat committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    28e9359 View commit details
    Browse the repository at this point in the history

  2. reformatting and splitting black and pylint sections

    @AmyOctoCat
    AmyOctoCat committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    fe0c39e View commit details
    Browse the repository at this point in the history

  3. Update exercises 1 and 2 with blank lines to match changes to later e… 

    …xercises (blank lines not picked up by black).
    @jatkinson1000
    jatkinson1000 committed Jun 27, 2024
    Configuration menu
    Copy the full SHA
    61e5ced View commit details
    Browse the repository at this point in the history

Commits on Jul 3, 2024

  1. remove redundant use of xr.DataArray wrapping around array multiplica… 

    …tion
    @AmyOctoCat
    AmyOctoCat committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    cf759c8 View commit details
    Browse the repository at this point in the history

  2. change font size in slides

    @AmyOctoCat
    AmyOctoCat committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    99ef3a9 View commit details
    Browse the repository at this point in the history

  3. remove remaining uses of assert in production code

    @AmyOctoCat
    AmyOctoCat committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    8e478f2 View commit details
    Browse the repository at this point in the history

  4. formatting changes to slides on naming

    @AmyOctoCat
    AmyOctoCat committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    f9a016d View commit details
    Browse the repository at this point in the history

  5. Merge pull request #13 from Cambridge-ICCS/jatkinson1000-naming-patch 

    Patch whitespace on naming exercise updates
    @AmyOctoCat
    AmyOctoCat committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    50e4972 View commit details
    Browse the repository at this point in the history

  6. Minor typographical updates.

    @jatkinson1000
    jatkinson1000 committed Jul 3, 2024
    Configuration menu
    Copy the full SHA
    6539266 View commit details
    Browse the repository at this point in the history