Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes from dry run #15

Merged
merged 3 commits into from
Jul 5, 2024
Merged

Changes from dry run #15

merged 3 commits into from
Jul 5, 2024

Conversation

MarionBWeinzierl
Copy link

Closes #14 . Implement some of the changes from the dry run (see issue)

@MarionBWeinzierl MarionBWeinzierl self-assigned this Jul 4, 2024
Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MarionBWeinzierl a comment in there.

Also, I forget the exact discussion, but on reflection here I would definitely cut the 'config file' part as this is just TMI at the end of a packed session and never lands very well.
Leaving the slide in to be visible is an option, but I am certain I would not cover it.
If anything I think fstrings would be easier for people to grasp if we somehow find ourselves with extra time.

slides/_comments_docstrings.qmd Show resolved Hide resolved
@MarionBWeinzierl
Copy link
Author

Thanks @MarionBWeinzierl a comment in there.

Also, I forget the exact discussion, but on reflection here I would definitely cut the 'config file' part as this is just TMI at the end of a packed session and never lands very well. Leaving the slide in to be visible is an option, but I am certain I would not cover it. If anything I think fstrings would be easier for people to grasp if we somehow find ourselves with extra time.

Any preferences about leaving the slides in and skipping them, or commenting them out for the case you have time?

@MarionBWeinzierl
Copy link
Author

Thanks @MarionBWeinzierl a comment in there.
Also, I forget the exact discussion, but on reflection here I would definitely cut the 'config file' part as this is just TMI at the end of a packed session and never lands very well. Leaving the slide in to be visible is an option, but I am certain I would not cover it. If anything I think fstrings would be easier for people to grasp if we somehow find ourselves with extra time.

Any preferences about leaving the slides in and skipping them, or commenting them out for the case you have time?

For the time being I have removed both. However, not sure whether the title of the section is then still fitting (maybe with the "honorable mentions" it is), or whether it should be changed. Or another slide added to mention the stuff that we removed.

Copy link
Member

@jatkinson1000 jatkinson1000 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Punch it Chewie.

@MarionBWeinzierl I can't see we will have lots of spare time, so both removed is probably fine. We can always mention or demo if we feel the need to.

At this point let's get something deliverable for the summer school. We can refine and add back at a later date after next week if so desired.

@MarionBWeinzierl MarionBWeinzierl merged commit 6a03a5a into main Jul 5, 2024
1 check passed
@MarionBWeinzierl MarionBWeinzierl deleted the dryrun_changes branch July 5, 2024 06:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove some slides and exercises
2 participants