Update documentation on pt2ts readme to clarify where the Torchscript… #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… model will be saved.
ElliottKasoar
approved these changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clarify where the Torchscript model will be saved.
May close #52
Depends on whether we feel we should output the Torchscript to the local place a user is running
pt2tsfrom (currently what this PR clarifies) or to the place thept2tsscript is located (would require changes to the pt2ts code).Under principle of least surprise I would go for the former, but this does place it inside the CMake
builddirectory in the examples rather than alongside the model.I would argue that the examples are something of a contrived case, however, and in reality users will place pt2ts next to their python source and run to obtain the model alongside. They will also likely not be running the Fortran from the same directory as the python model and training in a 'real' application.